Closed apoorvyadav1111 closed 1 month ago
Thanks for this PR @apoorvyadav1111 . Fantastic effort. Everything looks good and we can now reuse evalError and evalResponse functions in all store evals. We may not ask others to do the changes again if other PRs are already in the last stage, we will do it by ourselves once all commands are migrated.
Also, I see your commit links are broken in the PR description for now, once it's added to master I believe it should work.
Thanks again. I just have one comment, post resolution of that feel free to merge.
Hi @AshwinKul28 , thanks for the review. It must be due to force-push, for the safer side, I will update the commits once the branch gets merged and will not be modified.
Hi @AshwinKul28 , Apologies I merged it before looking at the new commits, I can definitely raise a new PR right now and add those comments. I have updated the commit hashes for now.
Fixes: #1031 #1110
Checklist