search

DiceDB / dice

DiceDB is a redis-compliant, reactive, scalable, highly-available, unified cache optimized for modern hardware.
https://dicedb.io/
Other
6.88k stars 1.09k forks source link

Add support for `HGETALL.WATCH` command #1124

Open JyotinderSingh opened 1 month ago

JyotinderSingh commented 1 month ago

Add support for reactive queries on the existing HGETALL command by introducing HGETALL.WATCH.

This command should send push-responses to subscribed clients whenever the data inside the respective hash set changes.

As a part of this feature, you are also required to add support for the same to the dicedb-go SDK inside the watch_command.go file.

Reference

  1. You may refer to #1047 to understand the changes required to support this command.

  2. 924 provides more background on the feature's underlying implementation (but may not be directly relevant to this issue)

Testing

  1. Ensure integration tests are added, you can refer to existing .WATCH integration tests.
  2. Integration tests should include both resp tests and SDK tests.
src1026 commented 1 month ago

Hi! Can I please work on this issue? Thank you : )

JyotinderSingh commented 1 month ago

Hi! Can I please work on this issue? Thank you : )

Assigned.

abhishekgupta1906 commented 1 month ago

Hi, could you please allow me to work on this issue?

arpit1912 commented 1 month ago

Hey @JyotinderSingh let me know the issue is still open, can take a quick look.

src1026 commented 1 month ago

Hey @arpit1912 ! I was working on it but I kinda got stuck on how to test my changes. I'm new so it took me longer than expected. Would you mind allowing me more time to look into this issue? Thank you.

JyotinderSingh commented 1 month ago

Hey @arpit1912 ! I was working on it but I kinda got stuck on how to test my changes. I'm new so it took me longer than expected.

Would you mind allowing me more time to look into this issue? Thank you.

Take your time. Feel free to ask on discord.

arpit1912 commented 1 month ago

Hey @arpit1912 ! I was working on it but I kinda got stuck on how to test my changes. I'm new so it took me longer than expected. Would you mind allowing me more time to look into this issue? Thank you.

Please do, I'm also new here and was just checking for an issue to work upon. Let me know if there is anything you want to discuss . Thanks!

tarun-29 commented 2 weeks ago

are you still working on this issue @src1026?