Open vinitparekh17 opened 2 days ago
can i take this up ?
Hey, I am fairly new to this project and I want to take this opportunity to get into contributing to DiceDB. Can I take up this task and return with a PR?
In expected response we need a json response or a json string?
{
"foo": {
"bar": 1
}
}
or
"{"foo":{"bar":"fooBar"}}"
In expected response we need a json response or a json string?
{ "foo": { "bar": 1 } }
or
"{"foo":{"bar":"fooBar"}}"
strigified response 2nd one
@vinitparekh17 Is it fine if the stringified version has escape characters in response?
Created a PR here - https://github.com/DiceDB/dice/pull/757/files
cc: @lucifercr07
Steps to reproduce
Expected output
Observed output
Suggestion
Please ensure that the value is properly serialized using json.Marshal before being sent as a response in the HTTP protocol.
Another Solution (Not Recommended, but Supported by Redis)
Expectations for resolution
This issue will be considered resolved when the following things are done
dice
code to meet the expected behaviorYou can find the tests under the
tests
directory of thedice
repository and the steps to run are in the README file. Refer to the following links to set up DiceDB and Redis 7.2.5 locally