Multiple changes, mainly bug fix for incorrect render of NavigationBar

DickyT / react-native-tabbar-navigator

(aka React Native Tanner Navigator) A component which builds excellent Navigator + TabBar based application, have a good solution for implementing hidesBottomBarWhenPushed in iOS.

97 stars 29 forks source link

Multiple changes, mainly bug fix for incorrect render of NavigationBar #6

Closed rahuljiresal closed 8 years ago

rahuljiresal commented 8 years ago

The navigation bar was not rendering correctly (gif 1 and gif 2). It has been fixed now (gif 3)

Gif-1 tabbar-2

Gif-2 tabbar

Gif-3 tabbar-correct

Added a hairline under the navigation bar just like native iOS.
Fixed problems where syntax issues were encountered because of the ES6 parser in larger projects with a plethora of dependencies. Replaced const with var, and import with var to make the parser happy.

DickyT commented 8 years ago

@rahuljiresal awesome! I will take a look tonight!

DickyT commented 8 years ago

@rahuljiresal I just merged to the master and finished some bug fix. You forget to update the navigation bar title while switching the tabbar lol

rahuljiresal commented 8 years ago

Oops! Thanks for the fix. This has been a great package! Solved a lot of my problems. I do have a couple of more changes, will submit them tonight.

DickyT commented 8 years ago

prefect, just make sure pull the latest code before you make any changes, or it will be hard to merge.