Dieterbe / anthracite

an event / change logging/managament app
Apache License 2.0
296 stars 33 forks source link

Permit WSGI usage of anthracite-web.py #18

Closed rpetre closed 9 years ago

rpetre commented 9 years ago

In order to run anthracite under uwsgi, I made a couple of changes in the anthracite-web.py file. Please consider merging the changes or implementing them better :)

Dieterbe commented 9 years ago

what's up with the application variable? you don't seem to use it, or is that something wsgi specific?

rpetre commented 9 years ago

It's a mod_wsgi thing (and it also applies to uwsgi): https://code.google.com/p/modwsgi/wiki/QuickConfigurationGuide#WSGI_Application_Script_File

Note that mod_wsgi requires that the WSGI application entry point be called 'application'. If you want to call it something else then you would need to configure mod_wsgi explicitly to use the other name. Thus, don't go arbitrarily changing the name of the function. If you do, even if you set up everything else correctly the application will not be found.

I admit I have very little experience hacking in Python, but my searches fo "running bottle under uwsgi" turned up a bunch of examples using application = app = bottle.Bottle() so I went for the same incantation and works for me, at least. The fix I made for graph-explorer is way worse, I was ashamed to submit it :)

Dieterbe commented 9 years ago

ok then, all this stuff is a bit of a mistery to me too, but it looks allright. thanks!