updated panel width - Githubissues

DigitalCommons / mykomap-monolith

A web application for mapping initiatives in the Solidarity Economy

0 stars 0 forks source link

updated panel width #28

Closed ms0ur1s closed 1 month ago

ms0ur1s commented 1 month ago

What? Why?

Related to @rogup's comment on PR #18, which relates to issue #272

Width of the panel looks too wide compared to designs.

Compared width of the panel component to its respective design
- The widths were the same, but perhaps the screen ratio of the designs made the panel looks smaller.
Reduced the desktop panel width from 450px to 400px.
- This can be easily amended at any time by updating the value of the CSS variable --panel-width-desktop within GlobalCSSVariables.tsx file.

What should we test?

What should we test?

Run storybook npm run storybook
Should run open automatically in your browser (or VS Code click dialogue as shown below)

Select a component to test

Checklist

[ ] Updated or added any necessary docs in docs/
[ ] Added UTs
[ ] Checked that all automated tests pass

rogup commented 1 month ago

@ms0ur1s looks good :) I'll merge it in

btw, remember to prefix commit messages with [front-end] or whatever subpackage you're changing, which a system that Nick recommended us to use

ms0ur1s commented 1 month ago

@rogup, thanks man 😁