DigitalCommons / mykomap-monolith

A web application for mapping initiatives in the Solidarity Economy
0 stars 0 forks source link

[CWM] Add language switching support to FE, based on URL parameter #31

Closed lin-d-hop closed 1 week ago

lin-d-hop commented 1 month ago

Description

We need to support the following languages:

As per the current MM implementation, the language will be specified by a language parameter in the URL. https://{URL}/?lang=FR

EN will be the default. If not language code is specified, return EN.

Feel very free to break this down into subtasks if helpful.

Acceptance Criteria

rogup commented 1 week ago

This is basically already done, all that was left was to add Hindi translations to the Delhi config.json

I've done that and saved the config.json into a new @mykomap/config library so we can version control changes @wu-lee Note this addition - so please make further changes to the config.json in the repo the copy it over to the data folder

https://github.com/DigitalCommons/mykomap-monolith/commit/cc520ce67f16a27a47fd3c726c71f2623e99baaa

rogup commented 1 week ago

Also @lin-d-hop note that the parameter is lang not language, which is already implemented in the code so didn't think it was worth changing it

ColmDC commented 1 week ago

Nice. Didn't know that we'd also get Hindi translations on the tiles too. :-)

rogup commented 1 week ago

Nice. Didn't know that we'd also get Hindi translations on the tiles too. :-)

That required a bit of a hack of the MapTiler styling, but thought it would be nice to do