DigitalCommons / mykomap-monolith

A web application for mapping initiatives in the Solidarity Economy
0 stars 0 forks source link

[CWM] Convert backend to Typescript & implement API type safety / validation #6

Closed rogup closed 1 month ago

rogup commented 2 months ago

Description

Following on from the investigation in https://github.com/DigitalCommons/mykomap/issues/269 , we need to have a go at implementing ts-rest + Zod on the backend.

Acceptance Criteria

wu-lee commented 2 months ago

Back-end is now typescript, as of e5b84f86450. Initially with @ts-nocheck but those are now removed.

The tsconfig.json is using strict, but I'm not certain how strict the typing is however. I have a feeling we got Mykomap 3.0 to be more strict than this. Will investigate in future work, however.

wu-lee commented 1 month ago

@rogup I've just submitted a review request for the branch ts-restify-the-backend here: https://github.com/DigitalCommons/mykomap-monolith/pull/15

This should cover the final two points on the list above. (But not including uploading the swagger spec.)

wu-lee commented 1 month ago

Merged a while ago, I think this is done, so closing.