DigitalState / Cms

The DigitalState Cms Microservice
MIT License
5 stars 2 forks source link

The entire batch request fails if one of the requested entities does not exist #10

Closed baddlan closed 6 years ago

baddlan commented 6 years ago

Sample request: GET http://api.cms.demo.digitalstate.io/app_dev.php/content?texts[]=portal-title&files[]=some-nonexistent-file-slug

Response: 404 Not found

It would be nice to ignore missing entities.

marioprudhomme commented 6 years ago

Fixed c04928c24204ef91d890ecc69a529c6df875c7cc

baddlan commented 6 years ago

When fetching multiple (existing) file entities, only one entity appears complete in the response, the rest get null values.

Test:

http://api.cms.demo.digitalstate.io/app_dev.php/content?texts[]=admin-title&files[]=admin-logo-login&files[]=admin-logo-header&files[]=admin-logo
marioprudhomme commented 6 years ago

Fixed b930e75cae0096045e0dda56c1bc9d67b856d228