search

DillonB07 / Animal-Crossing-Music-Bot

Discord Animal Crossing Music Bot - Plays hourly music from different games. Has real-life weather dependent tunes and KK songs!
6 stars 2 forks source link

Improve error handling #5

Open DillonB07 opened 1 year ago

DillonB07 commented 1 year ago

Add more descriptive error handling. For example, if the bot cannot see the channel, say that instead of saying something went wrong.

Bug found by @Raadsl - https://discord.com/channels/1021488037001183362/1021488037001183365/1118203913858986015

Raadsl commented 1 year ago

Also when you disconnect the bot without doing /stop it spams these messages image

DillonB07 commented 1 year ago

Oh, whoops! That makes sense, I'm just disconnecting the bot from the vc and not stopping the coroutine. Not sure how to tackle that one. Perhaps just add a playing field in the db and it'll check that before playing something and exit the func if it's set to False.

Will try and do that in a few days - got some other important stuff to do first. Feel free to PR if you want it done sooner.

Thanks for reporting!

Raadsl commented 1 year ago

I don't know much about mongo, but I'll take a look at it

DillonB07 commented 1 year ago

@Raadsl Fixed your issue via https://github.com/DillonB07/Animal-Crossing-Music-Bot/commit/ed5ea1fe9e695f22d89e21c3975f648d67b90cdd Will keep this issue open as I still need to improve error handling.

My suggested method for fixing this issue was really silly - not sure why I thought that was a good idea as I can just check the status of the voice client in the function and break if it's not in a vc.

Raadsl commented 1 year ago

@DillonB07, errrors Also got these, but can't replicate them after I kicked and reinvited the bot to make it stop. Just so you know

DillonB07 commented 1 year ago

Got a feeling that the fix for the spammed no vc error would've fixed that. Let me know if you get it again though.

DillonB07 commented 6 months ago

Anyone who was pinged by the scammer, make sure to not click on any of the links - doing so could give them read-write access to all of your GitHub repositories which they could delete or hold ransom or do anything with.