search

Dindaleon / hapi-react-starter-kit

A hapi React Starter kit with react-router, redux, react-transform
172 stars 29 forks source link

Cleanup dependencies in package.json #18

Open utvk opened 8 years ago

utvk commented 8 years ago

Some of the dependencies in package.json, e.g. the babel deps, should probably be moved from dependencies to devDependecies?

utvk commented 8 years ago

Also: Do you use "karma-phantomjs2-launcher": "^0.4.0",? maybe remove if not in use?

Dindaleon commented 8 years ago

I did move some devDependencies to dependencies on purpose to ease the building process for production deployment. If we move those back to devDependencies, then we can build the app on local and then deploy it. I don't know if that will cause issues on travis, I have not tried it. When I get the time, I will give it a shot and see what happens.

I am not using that launcher at the moment, so yes, it has to be removed.

Thank you for the heads up.