search

Distributive-Network / PythonMonkey

A Mozilla SpiderMonkey JavaScript engine embedded into the Python VM, using the Python engine to provide the JS host environment.
https://pythonmonkey.io
Other
854 stars 40 forks source link

Upgrade SpiderMonkey to mozilla-central commit `bc4609b7aa7a3dff961f43d527bc66c5c85f6f4b` #375

Closed github-actions[bot] closed 4 months ago

github-actions[bot] commented 4 months ago

Changeset: https://hg.mozilla.org/mozilla-central/rev/bc4609b7aa7a3dff961f43d527bc66c5c85f6f4b

Xmader commented 4 months ago

Testing https://github.com/Distributive-Network/PythonMonkey/pull/367/commits/a7b92e896ff6b077f161b9ae79a9f5e55f4434b5

Xmader commented 4 months ago

TODO: Why can't this trigger a CI build?

Found in https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target

To ensure repository security, branches with names that match certain patterns (such as those which look similar to SHAs) may not trigger workflows with the pull_request_target event.

Also found https://github.com/marketplace/actions/add-commit#the-commit-from-the-action-is-not-triggering-ci (by https://www.reddit.com/r/github/comments/x0h8v5/comment/imrczmr/)

Updated branch protection rule to make sure the build CI passes before we can merge.

Xmader commented 4 months ago

@philippedistributive For PRs created by https://github.com/Distributive-Network/PythonMonkey/commit/a7b92e896ff6b077f161b9ae79a9f5e55f4434b5 like this, it should be good to merge as long as the build CI (https://github.com/Distributive-Network/PythonMonkey/blob/main/.github/workflows/test-and-publish.yaml, not the CodeQL ones) passes.