search

Divested-Mobile / Mull-Fenix

Build scripts for a web browser built upon Mozilla technology
https://divestos.org/pages/our_apps#mull
GNU Affero General Public License v3.0
610 stars 16 forks source link

Enable PDF loading in tabs from Mull 109? #104

Closed opusforlife2 closed 1 year ago

opusforlife2 commented 1 year ago

https://bugzilla.mozilla.org/show_bug.cgi?id=1754499

The ability to open PDFs in tabs has been added in Nightly. However, pdf.js has been disabled through its pref. Is it possible to enable the pref in Mull 109?

The patch contains some 4-5 pref changes, including the one disabling pdf.js. Not sure whether the others should be changed or left alone.

SkewedZeppelin commented 1 year ago

https://github.com/Divested-Mobile/Mull-Fenix/blob/1890af2d3b055ac208c3e8c94a9d15293a2a1b08/preferences/userjs-arkenfox.js#L664 The akenfox.js explicitly enables pdf.js, so when it lands it should work. I already test it not there yet in 108.

Thorin-Oakenpants commented 1 year ago

RFP explicitly enables pdfjs

https://github.com/Divested-Mobile/Mull-Fenix/blob/1890af2d3b055ac208c3e8c94a9d15293a2a1b08/preferences/userjs-arkenfox.js#L837

opusforlife2 commented 1 year ago

I tried several PDFs. This isn't working. Maybe one of those linked prefs needs tweaking?

SkewedZeppelin commented 1 year ago

It isn't there yet https://bugzilla.mozilla.org/show_bug.cgi?id=1810106 https://bugzilla.mozilla.org/show_bug.cgi?id=1803753

edit 2023/02/09: more progress https://bugzilla.mozilla.org/show_bug.cgi?id=1815730

opusforlife2 commented 1 year ago

Those are merely for feature polish. Bells and whistles like searching in the PDF, and form support. Nightly is able to open PDFs perfectly fine. So there must be a way to enable it for Mull.

opusforlife2 commented 1 year ago

Lol: https://bugzilla.mozilla.org/show_bug.cgi?id=1817400

opusforlife2 commented 1 year ago

111 out on F-Droid. PDFs open in tabs.