search

Divinelink / scenepeek-android

ScenePeek is an Android Application that provides information about movies, television shows & persons using the TMDB API.
0 stars 0 forks source link

Multi-Module #45

Closed Divinelink closed 6 months ago

Divinelink commented 6 months ago

In this pull request we've made several improvements regarding our application codebase, the most crucial one being the multi module approach.

We've introduced five new core modules:

Additionally, for security reasons, we've updated how we retrieve the "tmdb_auth_token" needed to handle API calls. Previously, we were using remote config to fetch the auth token, but that was not secure enough, as people could easily debug the code and see the token. To fix that the token is now stored in the local.properties file that is not uploaded to version control.

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 66.66667% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 66.15%. Comparing base (d45400f) to head (5a89512). Report is 1 commits behind head on main.

Files Patch % Lines
...m/andreolas/movierama/details/ui/DetailsContent.kt 25.00% 0 Missing and 3 partials :warning:
...home/domain/usecase/FetchMultiInfoSearchUseCase.kt 0.00% 3 Missing :warning:
...andreolas/movierama/details/ui/DetailsViewState.kt 50.00% 0 Missing and 1 partial :warning:
...gin/domain/session/usecase/CreateSessionUseCase.kt 0.00% 1 Missing :warning:
...ama/settings/components/AlertDialogSelectOption.kt 0.00% 1 Missing :warning:
...ma/ui/components/details/reviews/ReviewItemCard.kt 50.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #45 +/- ## ========================================== + Coverage 62.97% 66.15% +3.17% ========================================== Files 156 95 -61 Lines 3787 2783 -1004 Branches 656 574 -82 ========================================== - Hits 2385 1841 -544 + Misses 1074 642 -432 + Partials 328 300 -28 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.