DivvyCr / Balatro-Preview

Simulate the score you will get on the selected cards!
GNU General Public License v3.0
45 stars 5 forks source link

fix: Amber Acorn not hiding score when hide score option is selected #25

Closed CUexter closed 6 months ago

CUexter commented 7 months ago

My goal here is to solve #24.

The logic is simple, if the boss is amber acorn and the number of joker is not zero, then hide the scores

CUexter commented 7 months ago

I haven't test the fix, how do i test it without playing the game from scratch ?

CUexter commented 7 months ago

I have tested the fix, and it worked, however i found a more pressing bug when testing #26

DivvyCr commented 7 months ago

Appreciate the PR, but I believe a more robust approach would be something like this:

for _, joker in ipairs(G.jokers.cards) do
   if joker.facing == "back" then return nil end
end

Could you test if it works and update the PR?

CUexter commented 7 months ago

it works, however the ??? is shown even when no cards are selected, do you want this behavior ? or if you want an extra check ?

CUexter commented 7 months ago

Ok i added the feature to only show ??? when cards are selected, also i implemented fixes for #26

DivvyCr commented 7 months ago

LGTM. I'll merge after testing for myself, hopefully today/tomorrow.