fix serializing for array type attributes

DmitryTsepelev / store_model

Work with JSON-backed attributes as ActiveRecord-ish models

MIT License

1.04k stars 85 forks source link

fix serializing for array type attributes #175

Closed safakferhatkaya closed 3 months ago

safakferhatkaya commented 3 months ago

After the introduction of https://github.com/DmitryTsepelev/store_model/pull/171, we are still facing the issue of serializing after, #173. For to_array_type attributes.

Description quoted from #173: This PR first checks if the array is empty, before validating if all values are StoreModel::Model objects. For many many_base class objects

DmitryTsepelev commented 3 months ago

hey hey, could you please check if https://github.com/DmitryTsepelev/store_model/pull/176 solves the issue? I merged that one cause there were specs 😅

safakferhatkaya commented 3 months ago

hey, yes #176 serves the same purpose its ok. thanks

safakferhatkaya commented 3 months ago

[duplicated] #176 resolves the same issue