search

DoSomething / chompy

:card_index: The DoSomething.org third-party importer.
MIT License
1 stars 0 forks source link

Upgrade to Laravel 6.0 #177

Closed DFurnes closed 4 years ago

DFurnes commented 4 years ago

What's this PR do?

This pull request upgrades Chompy to Laravel 6.0, the latest long-term service release.

How should this be reviewed?

1️⃣ Updated Laravel 5.7 to Laravel 5.8, following the upgrade guide in 41fd1c7.

2️⃣ Updated from Laravel 5.8 to 6.0, following the upgrade guide in a94b9e5. Because Laravel 6.0 requires Carbon 2, I also upgraded to Gateway 3.0. This involved updating to the new getUser signature, which use Northstar's v2/ APIs.

🙈 I've removed some usage of "sensitive" fields, like mobile and last_name that didn't seem necessary in 045e39b. These are no longer returned in the standard response in Northstar's v2/ APIs & usage should be avoided if possible.

Any background context you want to provide?

This is part of our "Q3 Upgrades" epic, and ensures that we keep getting security and bug fixes! It also includes new features, so it's worth skimming the Laravel 5.8 Release Notes and Laravel 6.0 Release Notes to see what's new! 🆕

Relevant tickets

References Pivotal #172383688.

Checklist

DFurnes commented 4 years ago

@aaronschachter Pinging you for an extra set of eyes since you're probably the most familiar with these jobs!

In particular, I'm curious if you can think of any places where Northstar's new v2/ APIs (which don't include sensitive fields like email, mobile, addr_street1, etc) might cause us trouble here. It seems like we only read these values on the incoming CSV, so should be fine but let me know if anything comes to mind!

aaronschachter commented 4 years ago

Testing this out locally, and running into Class 'Illuminate\Support\Facades\Input' not found over in https://github.com/DoSomething/chompy/blob/586b32b905498d89abc2cde7e3d124bf0b3d7d52/app/Http/Controllers/Web/ImportFileController.php#L188

when using the Test Import form.

DFurnes commented 4 years ago

Strange! I can't imagine how that was working in the first place. 🤔 I can fix up in my follow-up PR.