search

DoSomething / voting-app

☑ Voting app for DoSomething.org campaigns.
MIT License
6 stars 4 forks source link

Clean up files created during tests before bundling for deploy. #445

Closed DFurnes closed 9 years ago

DFurnes commented 9 years ago

Changes

The PHPUnit test suite creates a set of images when seeding the database in public/images. Unfortunately, these are then getting bundled up when Wercker saves build output to be used for deploys, and Capistrano is getting unhappy when it finds a folder of :cat:s where it wants to make it's symlink This updates the Wercker build to clean up after itself.

Is this the best way of handling this? We want the rest of the build to be consistent between testing and deploy (Composer and NPM dependencies, built CSS and JS, etc.) so I think this is the right path, but would love any thoughts otherwise!

Closes #444.

How should this be manually tested?

When this branch deploys, does it :bomb:? Hopefully not.

For review: @angaither @blisteringherb

angaither commented 9 years ago

:bomb: :boom:

DFurnes commented 9 years ago

WELL HERE WE GO :game_die:

blisteringherb commented 9 years ago

Woo hoo! Looks like it works. :+1:

DFurnes commented 9 years ago

:tada: