Updates the form & validation logic as specified in #439. All users are now required to provide an email address, and US, BR, and MX may optionally provide a cell number as well.
How should this pull request be tested?
The test suite has been updated to check the new expected behavior (see VotingTest.php in the diff). Additionally, functionality can be manually tested on Cats Gone Good by adding ?country_code=XX to the URL to spoof your country code.
Screenshots
Look, screenshots! :mount_fuji:
US users see a cell phone field:
BR users see a mobile phone field:
MX users see a mobile phone field:
ES users just get the email field because nobody wants their numbers:
angaither
commented
9 years ago
Changes
Updates the form & validation logic as specified in #439. All users are now required to provide an email address, and
US,BR, andMXmay optionally provide a cell number as well.How should this pull request be tested?
The test suite has been updated to check the new expected behavior (see
VotingTest.phpin the diff). Additionally, functionality can be manually tested on Cats Gone Good by adding?country_code=XXto the URL to spoof your country code.Screenshots
Look, screenshots! :mount_fuji:
US users see a cell phone field:
BR users see a mobile phone field:
MX users see a mobile phone field:
ES users just get the email field because nobody wants their numbers:
For review: @angaither