[BREAKING] Delete in-viewport mixin

DockYard / ember-in-viewport

Detect if an Ember View or Component is in the viewport @ 60FPS

MIT License

245 stars 91 forks source link

[BREAKING] Delete in-viewport mixin #292

Closed SergeAstapov closed 2 years ago

SergeAstapov commented 2 years ago

@snewcomer @cibernox FYI I'm still working on removal of in-viewport mixin which was slated for v4.0

SergeAstapov commented 2 years ago

@snewcomer @cibernox this is now ready for your review and targets a next major release as it's breaking change (planned for v4 but the release was cut before we finished this).

Bug thanks to @sergeykers and @andrei-sviazhin for they help!

SergeAstapov commented 2 years ago

@snewcomer yeah, sounds like a plan! mind to merge and release if all looks good?

snewcomer commented 2 years ago

I'll let @cibernox merge when he was a moment!

SergeAstapov commented 2 years ago

@cibernox just a friendly ping on this PR

cibernox commented 2 years ago

Merged! I suppose I should release 5.0 now tho. No big deal, numbers are cheap.

SergeAstapov commented 2 years ago

@cibernox yes, please do v5! So we follow semver and not troll users of this addon