make in-viewport compatible to ember-modifier v4

DockYard / ember-in-viewport

Detect if an Ember View or Component is in the viewport @ 60FPS

MIT License

245 stars 91 forks source link

make in-viewport compatible to ember-modifier v4 #306

Closed And012 closed 1 year ago

And012 commented 2 years ago

Closes # .

Changes proposed in this pull request

And012 commented 2 years ago

Have removed ember-default-with-jquery snenario. jquery-integration optional feature flag to true was deprecated in Ember 3.x and removed in Ember 4.0.0.

SergeAstapov commented 2 years ago

@cibernox @snewcomer would you be able to review/land this?

miguelcobain commented 1 year ago

Would love to get this fixed to get rid of deprecations. 👀

miguelcobain commented 1 year ago

When can we expect a release? 🙏

miguelcobain commented 1 year ago

@snewcomer can we release, please?