search

DockYard / ember-service-worker

A pluggable approach to Service Workers for Ember.js
http://ember-service-worker.com
MIT License
238 stars 63 forks source link

Replace broccoli-uglify-sourcemap with broccoli-terser-sourcemap #190

Open mydea opened 3 years ago

mydea commented 3 years ago

broccoli-uglify-sourcemap was replaced with broccoli-terser-sourcemap, which is included in ember-cli by default for some time now. Basically, broccoli-terser-sourcemap is v4 of broccoli-uglify-sourcemap.

Also the build step currently looks at minifyJS option set in ember-cli-build of the host app. This hasn't really been working properly for some time, especially when using ember-cli-terser. For this, you specify the options differently.

I have adjusted it to keep working for minifyJS for now, although the options will not work because the format is different. I would say it is OK (I output a warning in this case), as on the flipside it will completely ignore any terser settings an up-to-date app would have.

charlesfries commented 2 years ago

Anything I can do to help get this merged in?