search

Dogway / Avisynth-Scripts

AviSynth+ 3.7.3+ Filters
GNU General Public License v3.0
92 stars 13 forks source link

Typo in QTGMC+.avsi #73

Closed ChristianWaechter closed 1 year ago

ChristianWaechter commented 1 year ago

Describe the bug I was updating to the latest files of your repository because I wanted to try out the BM3D denoiser. But with my usual call for QTGMCp(), I got an error complaining about a a invalid preset

Avisynth open failure: ex_BM3D: Wrong 'preset' mode (AviSynth_Plugins/SMDegrain.avsi, line 1129) (AviSynth_Plugins/QTGMC+.avsi, line 557)

Files This was a typo in the QTGMC+.avsi file in line 555. It should be Normal but is Normsl

(Denoiser == "BM3D") ? noiseWindow.ex_BM3D(sigma=Sigma,radius=NoiseTR,preset="Normsl",UV=3 ,gpuid=gpuid )

Dogway commented 1 year ago

Thanky! Ok as a preset or maybe I should default sigmas? Didn't account for BM3D so it might be misleading (using the default ones)

ChristianWaechter commented 1 year ago

I'm not sure either. Presets might be more usefull as a meaningfull naming of the preset might help to choose a suitable preset wich than includes a sigma-value. At least it would be obvious that one would use a very noisy preset on a noisy source. But is it not so obviouse which sigma-value to start.

By the way, is there a explanation what the different presets are doing?

Dogway commented 1 year ago

'Presets' is mainly an accuracy selector, you can see the table here. The problem when associating it noise levels is that for example I often want to accurately deinterlace but not denoise or not at least with QTGMC+, so for noise levels you have extra options like SourceMatch, EZDenoise, EZKeepGrain, and obviously thSAD1 and 2.

I ran a test and default sigma for BM3D seemed acceptable. Closing for now.