search

DoktorNik / course-companion

BrockU CSC Course Companion
1 stars 1 forks source link

Migrate completed course relationship to single-pivot representation #25

Closed gideonoludeyi closed 4 months ago

gideonoludeyi commented 4 months ago

Continuing off https://github.com/DoktorNik/course-companion/pull/23, this PR identical changes for the completed course double-pivot relationship: fromcompleted_courses + completed_courses_courses double-pivot table into a single completed_courses_v2 single-pivot table.

See https://github.com/DoktorNik/course-companion/pull/23 and https://github.com/DoktorNik/course-companion/issues/24 for more details.

[!NOTE] The completed_courses_v2 table should be renamed to completed_courses after the current completed_courses + completed_courses_courses double-pivot relationship is removed.

Course Companion WIP
Current schema once this PR is merged
DoktorNik commented 4 months ago

Thanks for your continued work on this.

I'm concerned that removing the check for existing courses completed will cause an error in a situation where someone creates a student without any courses completed yet.