Fix: array.push and friends register two (instead of one) data nodes? - Githubissues

Domiii / dbux

Dbux is an Integrated Debugging Environment (IDbE) and Omniscient Debugger that makes JavaScript application's run-time behavior come alive, visible and interactive.

https://domiii.github.io/dbux

Apache License 2.0

161 stars 13 forks source link

Fix: array.push and friends register two (instead of one) data nodes? #669

Closed Domiii closed 2 years ago

Domiii commented 2 years ago

For Array.push, two DataNodes are added, both have input set to the argument tids:

One Write on the BCE
- added by builtins/array.js
One Read on the CRE
- added by RuntimeMonitor.traceCallResult

Notes:

The trace added by traceCallResult is correct, with inputs set to null.
However, they are later overridden by resolveMonkeyParams because monkey.wireInputs set to true.
That function sets argument data nodes as inputs for the monkey-patched DataNodes, that have been added to the BCE.
The weird thing is that this is not at all necessary, since that's already taken care of → Maybe it was necessary in the past?

Sln:

[x] for now, remove resolveMonkeyParams, because there does not seem to be a need for the re-wiring.
[x] test w/ arrays-push*.js

future-work: Maybe consider moving the DataNodes from BCE to CRE?

Screenshot

Somehow, there are two DataNodes for the push call, both have input set to the pushed value's dataNodeId (19 in this case).