search

DonJayamanne / javaVSCode

Extension for java development on VSCode (deprecated)
https://marketplace.visualstudio.com/items?itemName=donjayamanne.javaDebugger
MIT License
43 stars 29 forks source link

Add separate option for classpath #45

Closed rianadon closed 7 years ago

rianadon commented 7 years ago

This fully resolves #37 by creating a new option in launch.json for setting the classpath as an array, which gets joined by the correct OS-dependent separator. By doing this it also allows the launch configuration to work on multiple platforms.

Since this changes the proper structure of launch.json, I figured it may be a good idea to have a warning when the classpath is specified inside the options key of launch.json. Therefore, the PR includes a change to output the warning in the debug console. However, I'm not sure if this would be an important enough change to bring to people's attention, or if giving the warning this way is the best way to do it.

VS Code also trimmed a lot of trailing whitespace. Hopefully that's okay.

faustinoaq commented 7 years ago

Awesome, Thank you! This PR improve a lot classpath management :+1: