DonSimerino / CODE-DaWeSys

0 stars 1 forks source link

Attention: You should never ever push API keys to Github. #14

Closed eliasgruenewald closed 3 years ago

eliasgruenewald commented 3 years ago

Fortunately, this is still a private repository. However, after making it public (e.g. at the end of the semester), this could be automatically scraped by "evil" scammers.

Either keep a local version of that file with the real key or think about .env files, environment variables etc.

Further reading: https://medium.com/poka-techblog/the-best-way-to-store-secrets-in-your-app-is-not-to-store-secrets-in-your-app-308a6807d3ed

https://github.com/DonSimerino/CODE-DaWeSys/blob/9e66d8286c763b8d29ca77f13d70a5f1b959dec9/Database_communication/safeBrowsing/main.py#L3

dianabaumann commented 3 years ago

@moritz155 Valid point 🤔

moritz155 commented 3 years ago

I took the easy way out and unvalidated the api keys.