Breaking: move to JSONStream. remove multibyte option - Githubissues

DonutEspresso / big-json

A stream based implementation of JSON.parse and JSON.stringify for big POJOs

MIT License

114 stars 9 forks source link

Breaking: move to JSONStream. remove multibyte option #6

Closed DonutEspresso closed 7 years ago

DonutEspresso commented 7 years ago

This moves this module to JSONStream.

The granularity provided by json-stream is nice but was causing parse operations to take much longer than expected. It looks like JSONStream by default using the $* path separates on top level fields, which may be "good enough" for most big JSON cases.

There might be something interesting around customizing the JSONStream path to target parts of the big POJO where known tokens are too large. Could be something for 2.x.

opts.multibyte is also no longer necessary since JSONStream's underlying jsonparse handles it already.

coveralls commented 7 years ago

Coverage increased (+3.02%) to 97.959% when pulling a2d3616c8b23e8f855c4e00e6915591b09be2da7 on jsonstream into 58aaa927b36c7f9577171293e16befdd18631e1f on master.

coveralls commented 7 years ago

Coverage increased (+3.1%) to 98.077% when pulling a1ab36c793d3a2d5cb3d5c88788d1fd61e756ad1 on jsonstream into 58aaa927b36c7f9577171293e16befdd18631e1f on master.

coveralls commented 7 years ago

Coverage increased (+3.1%) to 98.077% when pulling 6997417bb9f2a2500096492c0627166d55507e9f on jsonstream into 58aaa927b36c7f9577171293e16befdd18631e1f on master.

coveralls commented 7 years ago

Coverage increased (+3.1%) to 98.077% when pulling 6997417bb9f2a2500096492c0627166d55507e9f on jsonstream into 58aaa927b36c7f9577171293e16befdd18631e1f on master.

coveralls commented 7 years ago

Coverage increased (+3.1%) to 98.077% when pulling 6997417bb9f2a2500096492c0627166d55507e9f on jsonstream into 58aaa927b36c7f9577171293e16befdd18631e1f on master.

coveralls commented 7 years ago

Coverage increased (+3.2%) to 98.148% when pulling c51b520acc3bc4b1353168833aefd454eceb0a1a on jsonstream into 58aaa927b36c7f9577171293e16befdd18631e1f on master.

coveralls commented 7 years ago

Coverage increased (+3.2%) to 98.148% when pulling c51b520acc3bc4b1353168833aefd454eceb0a1a on jsonstream into 58aaa927b36c7f9577171293e16befdd18631e1f on master.

coveralls commented 7 years ago

Coverage increased (+3.2%) to 98.148% when pulling c51b520acc3bc4b1353168833aefd454eceb0a1a on jsonstream into 58aaa927b36c7f9577171293e16befdd18631e1f on master.

coveralls commented 7 years ago

Coverage increased (+3.2%) to 98.148% when pulling 4dcfcf6e3767c3bd6d0549f46274862b4b236c73 on jsonstream into 58aaa927b36c7f9577171293e16befdd18631e1f on master.