search

Dopingus / cert-manager-webhook-dynu

Unofficial cert-manager webhook for dynu
Apache License 2.0
7 stars 7 forks source link

update modulename #3

Closed rbaumgar closed 2 years ago

rbaumgar commented 2 years ago

update for the test suite

gitguardian[bot] commented 2 years ago

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Details of the secret
| Secret | Commit | Filename | Detected At | | | ------------------------- | ---------------- | --------------- | -------------------- | -------------------- | | Generic High Entropy Secret | fe5b4b7e7a3e3e6893945126a87b75ef931b2285 | testdata/dynu/dynu-secret.yaml | 16:41 February 17th, 2022 | [View secret](https://github.com/Dopingus/cert-manager-webhook-dynu/commit/fe5b4b7e7a3e3e6893945126a87b75ef931b2285#diff-4f25a0167af21923a020fd092383641dL3) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secret safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate this secret](https://docs.gitguardian.com/secrets-detection/detectors/generics/generic_high_entropy_secret#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/internal-repositories-monitoring/integrations/git_hooks/pre_commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.
GitGuardian is an automated secrets detection service.We help developers and security teams secure the modern software development process.

 

Our GitHub checks need improvements? Share your feedbacks
Dopingus commented 2 years ago

Hello Robert,

thanks for the PR. Looks good to me!

I noticed that you added a dynu secret. Is this an valid API key? If it is please remove it and invalidate it on dynu, otherwise your dynu account might get compromised.

Thanks & Regards

rbaumgar commented 2 years ago

Of course this ist not a valid one! I did not found how to easily replace dynamicly with an environment variable...

Thao-Nguyen Do @.***> schrieb am Do., 17. Feb. 2022, 18:33:

Hello Robert,

thanks for the PR. Looks good to me!

I noticed that you added a dynu secret. Is this an valid API key? If it is please remove it and invalidate it on dynu, otherwise your dynu account might get compromised.

Thanks & Regards

— Reply to this email directly, view it on GitHub https://github.com/Dopingus/cert-manager-webhook-dynu/pull/3#issuecomment-1043222887, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEWHASYHUDJAAXOGO2Q4Z43U3UWONANCNFSM5OVHEJUQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

Dopingus commented 2 years ago

Thanks for the confirmation!

Just wanted to make sure.

rbaumgar commented 2 years ago

Btw, I am workung on all these issued to make everything is workung perfekt. We, Red Hat, will release very soon a supported Operator based cert-manager, 1.7.1. This will require that the webhook is also operator based. The developer promised that only very few things has to bei updated...

Thao-Nguyen Do @.***> schrieb am Do., 17. Feb. 2022, 19:00:

Merged #3 https://github.com/Dopingus/cert-manager-webhook-dynu/pull/3 into master.

— Reply to this email directly, view it on GitHub https://github.com/Dopingus/cert-manager-webhook-dynu/pull/3#event-6092299616, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEWHAS3IUAOVSVA4H6ULOWTU3UZTRANCNFSM5OVHEJUQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.*** com>