search

Dopingus / cert-manager-webhook-dynu

Unofficial cert-manager webhook for dynu
Apache License 2.0
7 stars 7 forks source link

Fix installation instructions in README #8

Closed Dopingus closed 2 years ago

Dopingus commented 2 years ago

Fixes the documentation instructions to working commands

anon-software commented 2 years ago

We need to update this line too:

groupName: <YOUR_GROUP_NAME> # Use the groupName defined above

The group name is hardcoded to com.github.dopingus.cert-manager-webhook-dynu, it is not up to the user to choose it.

Further, the version number in chart.yaml should be updated too. Yes, it is pointless to do it for a README file change but the automatic build will fail if left unchanged.

Dopingus commented 2 years ago

We need to update this line too:

groupName: <YOUR_GROUP_NAME> # Use the groupName defined above

The group name is hardcoded to com.github.dopingus.cert-manager-webhook-dynu, it is not up to the user to choose it.

Further, the version number in chart.yaml should be updated too. Yes, it is pointless to do it for a README file change but the automatic build will fail if left unchanged.

I think the group name is already hard coded. I incremented the version in the chart.yaml as per your suggestions. Please kindly review again.

anon-software commented 2 years ago

Yes, the group name is set in the code, but README.md does not reflect it. Line 60 (or about) says

groupName: <YOUR_GROUP_NAME> # Use the groupName defined above

but it should match what is in the code and look like this:

groupName: com.github.dopingus.cert-manager-webhook-dynu
Dopingus commented 2 years ago

Yes, the group name is set in the code, but README.md does not reflect it. Line 60 (or about) says

groupName: <YOUR_GROUP_NAME> # Use the groupName defined above

but it should match what is in the code and look like this:

groupName: com.github.dopingus.cert-manager-webhook-dynu

You're right. I updated it accordingly.