search

Draggable / formeo

Drag & Drop Form Builder
http://draggable.github.io/formeo/
MIT License
533 stars 196 forks source link

feat: added sticky function to controls container #213

Closed markandrewkato closed 5 years ago

markandrewkato commented 5 years ago

Added a stickyControls function to the controls container when editing.

kevinchappell commented 5 years ago

Awesome work! Thank you!

markandrewkato commented 5 years ago

@kevinchappell Happy to help. Just one question, when will this PR be merged in the master branch? Asking because, this is my first time contributing to a plugin development. I don't know if I should use the PR request in my package.json or if the process of merging is quick, I'll just wait for it to be merged in the master.

Also, I used yarn because I'm having a problem building the module using npm. I don't know if this has an impact with regard to installing using npm. But right now, I can't seem to install the package using npm.

Thanks!

kevinchappell commented 5 years ago

@markandrewkato yarn is good, I'll see what the issue could be with npm. Generally PRs are quick to merge. You used the correct commit format so a release should automatically be generated allowing you to install form npm instead of resorting to github.

I'm at work so not able to test at the moment but I don't see anything that would cause regression issue so will merge now.

The new version should be available via yarn add formeo in about 10 minutes

markandrewkato commented 5 years ago

@kevinchappell got it. thank you.

kevinchappell commented 5 years ago

:tada: This PR is included in version 1.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: