first of all, thanks for this addon!
I've made several changes to the configuration and to the execution to improve compatibility aswell as extensible configuration.
I've tried to keep most of the configuration backwards compatible but the new attributes_property configuration is not BC compatible and thus, attributes are being omitted if not configured.
So what has changed?
Changed smartctl output to JSON by using --json argument
Made sensor name configurable (sensor_name)
Made sensors "Friendly Name" configurable (friendly_name)
Added flag to enable/disable performance check during startup (performance_check)
Added flag to enable/disable debug mode (debug) which passes the smartctl --json output to the output_file
Added configurable JSON property to parse "attributes" from (attributes_property)
So the attributes_property is a property within the JSON output passed to output_file when debug is enabled.
In my case, this is nvme_smart_health_information_log. I think, this differs from setup to setup and thus I wanted to have that configurable.
To avoid unnecessary I/O (writes of the output_file), it is now skipped when debug is false.
In case this is being merged, I'll switch back to this addon but for now I am using my fork.
Hey there,
first of all, thanks for this addon! I've made several changes to the configuration and to the execution to improve compatibility aswell as extensible configuration.
I've tried to keep most of the configuration backwards compatible but the new
attributes_property
configuration is not BC compatible and thus, attributes are being omitted if not configured.So what has changed?
--json
argumentsensor_name
)friendly_name
)performance_check
)debug
) which passes thesmartctl --json
output to theoutput_file
attributes_property
)So the
attributes_property
is a property within the JSON output passed tooutput_file
whendebug
is enabled. In my case, this isnvme_smart_health_information_log
. I think, this differs from setup to setup and thus I wanted to have that configurable.To avoid unnecessary I/O (writes of the
output_file
), it is now skipped whendebug
isfalse
.In case this is being merged, I'll switch back to this addon but for now I am using my fork.