Dragoon-Lab / topomath

TopoMath: a web-based algebra tutor
http://topomath.asu.edu
GNU Lesser General Public License v3.0
3 stars 0 forks source link

When both parameters and DRTs are given and parameters have default names the DRT should use those parameters #513

Open jonwetzel opened 5 years ago

jonwetzel commented 5 years ago

In this example, the DRTs should re-use the existing nodes except when they are missing, like DNormal and DConstruction. Instead the DRTs are getting new copies of every parameter like so:

image.png

The student then can't change the equation to the correct node since it has the same name.

This happens in:

jonwetzel commented 5 years ago

This is a critical bug because it student is unable to finish the problem without deleting the given DRTs or renaming the nodes first. Neither is intended.

riteshsamala commented 5 years ago

working on it currently

jonwetzel commented 5 years ago

After making the fix, test the following conditions:

With both DRTs and Params given:

  1. A model that has parameters with only default names (e.g. "DNormal"). In this case there should be no alien nodes because the parameters all have default names.
  2. A model that has no parameters with default names (e.g. all named things like "NormalDistance"). In this case, there should be alien nodes for all parameters because the parameters had non-default names.
  3. A model that has some parameters with default names and some parameters with non-default names. In this case, the DRTs should not make alien nodes for the parameters with default names and should make alien nodes for the parameters which had non-default names.