DreamExposure / DisCal-Discord-Bot

DisCal is a Discord Bot that links up to a Google Calendar to create, delete, edit, and announce events and more!
GNU General Public License v3.0
112 stars 44 forks source link

!events <# of days> #80

Closed smnc closed 3 years ago

smnc commented 4 years ago

Is your feature request related to a problem? Please describe. No

Describe the solution you'd like A system to limit the number of events by date range or display the events for th next x # of days

Describe alternatives you've considered Using the calendar display

Additional context

NovaFox161 commented 4 years ago

What would be the appropriate range to limit this too? a week? 2 weeks? A month? While this won't have any real effect on the bot itself, because the query to get the events will be a limited range pull, and the requests to create the messages will be automatically rate limited. A user requesting all events in a month in a server with a very active calendar could be waiting for awhile for all the messages to post.

And how would the command look. Perhaps !events days 7 and for a date range !events 2020/12/01-2020/12/31??

Once those questions are answered, I can work on building it into the bot

NovaFox161 commented 3 years ago

@smnc Any suggestions here. I'd love to get it added >.<

smnc commented 3 years ago

I think for the rate-limit issue, maybe we cap the number of total events the bot will display based on the rate-limits instead of hard-coding in a date range limit? When the bot hits the limit we have the bot display the calendar link with a message saying something like

DisCal has reached the limit of messages Discord will allow it to display right now, please adjust your date range or use the calendar link below to see more events."

It'd be cleaner and probably head-off a bunch of support tickets, lol.

And for the syntax, both? I think !event days 7 to see the next week will be the main use, but the ability to specify a date range would be invaluable for some guilds.

NovaFox161 commented 3 years ago

Oh shit, didn't think about that possibility at all. That should be a pretty solid solution honestly.

smnc commented 3 years ago

This is my sweet spot - just enough programming knowledge to know how stuff works, without knowing how to actually do it, lol.

NovaFox161 commented 3 years ago

So, think its gonna be:

Think that works? If so I should be able to add it within this milestone.

smnc commented 3 years ago

Sounds great!

NovaFox161 commented 3 years ago

Moving this to the 4.1.1 milestone. Same reasoning as #85 due to feature creep.

NovaFox161 commented 3 years ago

Added in commit ece73a8dd0c90bc465d487b4dea68643147def32. will be deployed as per milestone