[Bug] Buttons cannot be remapped after removing an unused controller outside of the game.

[Erodynamics]

Describe the bug Input cannot be remapped after removing an unused controller outside of the game

To Reproduce Steps to reproduce the behavior:

1. Attach two controllers that USC can recognize
2. Launch game, map every button to a controller
3. Close game
4. Disconnect the unused controller
5. Restart game
6. Go back to settings and remap a button

Expected behavior Prompt to remap button or knob

Screenshots

Desktop (please complete the following information):

• OS: Windows 10 Education 20H2
• GPU: GeForce RTX 2060 Super
• CPU: Ryzen 5 3600
• Version: 0.4.0, Git commit 2021-02-28_e76cb5b0

Additional Information

• The bug also stops the user from using the controller to navigate the menu.
• Used a DualShock 4 + DS4Windows along with a Yuancon to reproduce the issue, but this can most likely be reproducible with any two sets of controllers. The DualShock 4 was used as the disconnecting controller.
• Most likely an array out of bounds error, as the game uses a list of controllers that is created on startup.

Log file

[13:08:26][Info] Starting task "Application Setup"
[13:08:26][Info] Version: 0.4.0
[13:08:26][Info] Git commit: 2021-02-28_e76cb5b0
[13:08:26][Info] The locale was changed from C to English_Canada.utf8
[13:08:26][Info] Starting task "Font library initialization"
[13:08:26][Info] Finished task "Font library initialization" in  5 ms
[13:08:26][Info] Starting task "Creating Window"
[13:08:27][Info] Listing 1 Joysticks:
[13:08:27][Info] [0] "YuanCon" (16 buttons, 2 axes, 0 hats)
[13:08:27][Info] Finished task "Creating Window" in  299 ms
[13:08:27][Error] Out of range controller [1], number of available controllers is 1
[13:08:27][Info] Starting task "Audio Init"
[13:08:27][Info] Finished task "Audio Init" in  34 ms
[13:08:27][Info] Starting task "GL Init"
[13:08:27][Info] OpenGL Version: 3.3.0 NVIDIA 461.09
[13:08:27][Info] OpenGL Shading Language Version: 3.30 NVIDIA via Cg compiler
[13:08:27][Info] OpenGL Renderer: GeForce RTX 2060 SUPER/PCIe/SSE2
[13:08:27][Info] OpenGL Vendor: NVIDIA Corporation
[13:08:27][Info] Finished task "GL Init" in  21 ms
[13:08:27][Info] Starting task "Discord RPC Init"
[13:08:27][Info] Starting task "Check for updates"
[13:08:27][Info] Finished task "Discord RPC Init" in  0 ms
[13:08:27][Info] Starting task "Load Transition Screens"
[13:08:27][Info] Finished task "Load Transition Screens" in  49 ms
[13:08:27][Normal] Update check status code: 200
[13:08:32][Error] Failed to open joystick 1
[13:08:32][Error] Failed to open gamepad: 1
[13:10:14][Error] Failed to add IApplicationTickable
[13:10:16][Error] Failed to open joystick 1
[13:10:16][Error] Failed to open gamepad: 1
[13:10:18][Error] Failed to add IApplicationTickable
[13:10:24][Error] Failed to open joystick 1
[13:10:24][Error] Failed to open gamepad: 1
[13:10:26][Error] Failed to add IApplicationTickable
[13:10:37][Error] Failed to open joystick 1
[13:10:37][Error] Failed to open gamepad: 1
[13:10:39][Error] Failed to add IApplicationTickable
[13:10:45][Error] Failed to open joystick 1
[13:10:45][Error] Failed to open gamepad: 1
[13:10:47][Error] Failed to add IApplicationTickable
[13:13:37][Error] Out of range controller [1], number of available controllers is 1
[13:13:37][Normal] Update check status code: 200

[123jimin]

Reselecting any controller in the settings page will make it work.

[Drewol]

Should be fixed by 8c3bbb143d234ac7549857bfa4b18101cddb21a2