search

Drewol / unnamed-sdvx-clone

A game based on K-Shoot MANIA and Sound Voltex
MIT License
795 stars 96 forks source link

Local scores not being saved #591

Closed ogami1972 closed 2 years ago

ogami1972 commented 2 years ago

Describe the bug Profile's (player's) local scores are erased when switching between profiles

To Reproduce Steps to reproduce the behavior:

  1. Create two profiles, "A" and "B". Load profile "A".
  2. Complete any chart for the first time. The score will be displayed as high score for that chart.
  3. Back-out to settings and change profile to "B". Return to the previously played chart. "A"'s score will be gone, which I think is expected behavior. Play the chart as "B", and now you will see a score for "B".
  4. Back-out to settings and change to profile "A". Return to chart, and there will once again be no score for "A", as if the chart had never been played.

Expected behavior While I don't think scores from multiple profiles can be displayed, the profiles should have their own individual score history, yes?

Screenshots If applicable, add screenshots to help explain your problem.

https://youtu.be/pQ2kK2s0AdQ

Desktop (please complete the following information):

Additional context

Log file

ogami1972 commented 2 years ago

Update: Ok, so I get up this morning and go in, and now when I load my profile, I am seeing the scores I got from last night, so I am closing this "issue". I'm not sure what I am seeing, but if it happens again, I'll get a video.

ogami1972 commented 2 years ago

Hello!

Reopening with video.

https://youtu.be/pQ2kK2s0AdQ

Drewol commented 2 years ago

Hi, if you send your maps.db file I can take a look at how your scores have been saved.

ogami1972 commented 2 years ago

Hello!

Here's the file. Thank you!

ogami1972_maps_db.zip

Drewol commented 2 years ago

For the song specifically showcased in the video you appear to have a duplicate of it, at the moment scores only show for one entry if there are duplicates.

the duplicate charts are located at: songs\TAYEUS\Taes Fun Pack\nidhogg and songs\B4UTmay2018\01_ishoku\04_Nidhogg

ogami1972 commented 2 years ago

cool, thank you so much, i knew there was dupe, assumed they would just be treated as different charts as they are different paths. I'll try removing that and see if the behavior changes. Or maybe try another chart i know i only have one of.

ogami1972 commented 2 years ago

ok, so here's what I found:

  1. Removing the duplicate did indeed cause the scores to appear. There is a related issue in solving this. deleting a single duplicate within the game causes both copies to be deleted (i may be wrong about that, am about to test). Duplicates must be deleted through external file manager?
  2. The scores remain the same when profiles are changed, but the name changes on the scores. I've included a couple of pics.

IMG_20220607_132045_625 IMG_20220607_132137_377

Thanks again for looking at this with me, i find it very very interesting.

ogami1972 commented 2 years ago

CORRECTION: you can remove single copies in-game. However, I am certain I am not alone in having charts that may be considered the same, because they are the same song, but are different as they are in different locations. Am going to try and figure out a way to make it work.

ogami1972 commented 2 years ago

ok, yeah, the library is a mess of dupes, but you can file that under "not my problem", lol. I'll clean it up, maybe release my own library ;)

As for the scores, I can see that it is, in reality, expected behavior. I will put in a feature request for scores to be somehow tied to profiles. Ideally, I'd like to see the skill analyzer section work for each player/profile, i.e. you can test your skill there and see your personal progression. But that's another thing.

closed and thank you.