DroidKaigi / conference-app-2024

The Official Conference App for DroidKaigi 2024
Apache License 2.0
453 stars 201 forks source link

If there is a message in Session, it would be better to display it on the TimetableItemDetailScreen as well #1024

Closed kosenda closed 1 month ago

kosenda commented 1 month ago

Overview

The value “message” is included in the Timetable's information, and with TimetableList, the message can be understood, but with TimetableGrid, the message is only an icon, so it may not be possible to know the content of the message when the details are opened by tapping on it, I thought it would be better to display the message on the TimetableItemDetailScreen as well as on the TimetableList.

TimetableList TimetableGrid TimetableDetail

Sample

kosenda commented 1 month ago

@takahirom @nobonobopurin How about this one...? 🙇

takahirom commented 1 month ago

I completely agree with you. However, as you know, we don't have the design for it right now, and we don't have much time. I think adding an 8dp margin to the left of the sample you provided would be good for me. @nobonobopurin, what do you think?

nobonobopurin commented 1 month ago

@takahirom @kosenda I agree with you! Regarding the left and right margins on the session detail screen, the design shows 16dp, but it's currently implemented with 8dp. So, I'm okay with adding an extra 8dp margin to the left 😂 I've also updated Figma.

Figma

image

Corvus400 commented 1 month ago

I would like to work on this task.

takahirom commented 1 month ago

Thank you for addressing this high priority issue. 🙏