search

DroidKaigi / conference-app-2024

The Official Conference App for DroidKaigi 2024
Apache License 2.0
459 stars 199 forks source link

When returning after performing a favorite operation on SearchScreen, the favorite icon blinks momentarily #609

Open kosenda opened 3 months ago

kosenda commented 3 months ago

Overview

This is a very minor thing, but as the title says, if you operate a favorite in SearchScreen and then tap the back button or the back operation of the OS, the favorite icon will blink.

https://github.com/user-attachments/assets/767dbba1-4633-4a1d-8a8d-640824c31f11

takahirom commented 3 months ago

This might be difficult to resolve. If it requires very unmaintainable code, I think we don't need to fix it. However, you can try to fix it if you want.

kyanro commented 2 months ago

🙋

kyanro commented 2 months ago

After investigating, it was found that the issue was caused by the state of the last displayed favorites being momentarily reflected when returning to the screen.

It seems the issue can be resolved by ensuring that the latest state of the favorites is reflected in the display upon returning.

I’ve created a Pull Request to address this, but if there’s a better approach, I would appreciate any advice.

kyanro commented 2 months ago

I couldn't resolve the issue, so I will give up for now. 😢

https://github.com/DroidKaigi/conference-app-2024/pull/945#issuecomment-2344713034