DroidKaigi / conference-app-2024

The Official Conference App for DroidKaigi 2024
Apache License 2.0
457 stars 201 forks source link

Create a License screen that can also be used with ComposeMultiplatform. #813

Closed Corvus400 closed 2 months ago

Corvus400 commented 2 months ago

Why is this necessary?

The following is an overview of the list of tasks required to complete the task.

  1. [ ] Create feature:license module.
  2. [ ] Create License list screen.
  3. [ ] Create components for the license list screen.
  4. [ ] Creation of License detail screen that transitions from License list screen.
  5. [ ] Install the libraries described in the Link section.
  6. [ ] Creation of Data layer to handle artifacts.json provided by the library.
  7. [ ] Display the License list and License detail screen using the data provided by the Data layer.
  8. [ ] Create VRT for License list screen and detail screen.
  9. [ ] If necessary, we will create a design proposal and modify the screen according to the design.

Link

Corvus400 commented 2 months ago

@takahirom I've been thinking about the task. If you know of an easier way to accomplish this, I would like to follow the task accordingly. 🙇

takahirom commented 2 months ago

Can we open a Swift screen from Android? I think we can pass a lambda from Swift, so there might be a way.

Corvus400 commented 2 months ago

@takahirom I will try to see if I can't use the existing iOS code to handle the part of the code that opens the license screen. However, to show the potential of Compose Multiplatform, I will try to implement the described procedure once the existing license screen can be displayed. 🫡

takahirom commented 2 months ago

I think it is finished. Let me know if I'm wrong.

Corvus400 commented 2 months ago

@takahirom If you do not need to use the same license screen for Android/iOS, then you are done. :saluting_face: If you do this task, you will have the advantage of using a common screen for iOS and Android. However, there is a concern that if we execute this task, we do not know if we can make CI pass the task as long as we treat JSON as an artifact. :thinking:

Corvus400 commented 2 months ago

@takahirom If you don't need to make the license screen conform to Compose Multiplatform, you can finish it, but what should you do? 🤔

takahirom commented 2 months ago

I think creating a screen is not that difficult, but generating license information for both iOS and Android libraries would be challenging.

Corvus400 commented 2 months ago

There are still some major issues with Compose Multiplatform, so I'm going to focus on solving those issues and not do this task this time. 🫡