On Windows, terminating the CLI doesn't close the preview window reliably - Githubissues

Dropsource / monarch

Monarch is a tool for building Flutter widgets in isolation. It makes it easy to build, test and debug complex UIs.

https://monarchapp.io

MIT License

433 stars 22 forks source link

On Windows, terminating the CLI doesn't close the preview window reliably #59

Open fertrig opened 1 year ago

fertrig commented 1 year ago

On Windows, once Monarch has launched, if the user presses CTRL+C in the CLI, the preview window does not reliably close.

The cli task_runner is calling previewApi.terminatePreview() which shuts down the preview_api engine and the preview window. The error seems to be a timing issue. Some options:

Wait a little bit of time after we call terminatePreview or,
Wait for the _runPreviewAppTask process to reach a final state (with a timeout so the termination is not left hanging)