Fix issues with booking page

Dsek-LTH / web

The D-guild's primary web page

https://dsek.se

European Union Public License 1.2

22 stars 9 forks source link

Fix issues with booking page #434

Closed danieladugyan closed 3 months ago

danieladugyan commented 3 months ago

KM mentioned some issues about the new booking page. Collect issues here, split up into tasks and resolve.

[x] Members can't change their bookings
[x] KM can't change members bookings
[x] Members can't see what is booked
[x] KM can't remove peoples bookings
[x] Members can't remove booking
[x] The calender view is broken. Everthing is in the same colour.
[x] You can just see start time, no end time on bookis
[x] You can only see the "reason"/event name, not WHAT is booked
[x] You can't see who has booked something

No longer applicable. Fixed by showing more info in the calendar card.

[x] Member can't view bookings by clicking on them on the calender.

Macludde commented 3 months ago

More issues:

You can just see start time, no end time on bookis
You can only see the "reason"/event name, not WHAT is booked
You can't see who has booked something

Macludde commented 3 months ago

Look at this picture, it tells me almost nothing. I can't even see the full name. It is NOT clickable

danieladugyan commented 3 months ago

First release is up.

You can now delete bookings.
The calendar is removed in favour of a simple table.
Users are now redirected automatically to admin/create page if they have no bookings.

We should probably revisit the latter two points.

The calendar is especially useful if people often need to see bookings other than their own. I don't really use the page myself that much but I suppose it could be a common use case.
This can be somewhat confusing if you were expecting to have a booking request.

For now this was a quick and easy fix, you can at least see your own bookings clearly.

danieladugyan commented 3 months ago

Second release will be up soon. There's now a booking calendar that once again allows bookers to get a quick overview of what is booked and when.

It's currently only showed on the booking creation page. This might be controversial, but I think it makes sense for its primary use case of finding a good time slot for your booking. It discourages using the booking system to just check whether something you want is booked or not, without actually making a booking request yourself.

Feel free to open new issues, but barring any major oversights I think this issues can be deemed resolved for now.