search

Dubwise56 / Rimatomics

Nuclear power | Energy weapons | Nuclear weapons
41 stars 15 forks source link

Wrong skill description while Rimatomics mod is active #38

Open TheLonerD opened 1 year ago

TheLonerD commented 1 year ago

Skill description is broken if Rimatomics mod is active. This might happen because translation data have SkillLevel key defined. With no source code available it's hard to find where this key can be used.

Game version: 1.4.3580 rev1304 My mod list:

Mod list

```xml

  • brrainz.harmony
  • ludeon.rimworld
  • ludeon.rimworld.royalty
  • ludeon.rimworld.ideology
  • ludeon.rimworld.biotech
  • jaxe.rimhud
  • dubwise.rimatomics
    • ```

    Screenshots:

    With Rimatomics

    ![image](https://user-images.githubusercontent.com/6560567/210741896-e8567ccb-1b3e-4df2-b6dc-3d5c909be0db.png)

    Without Rimatomics

    ![image](https://user-images.githubusercontent.com/6560567/210744157-0dc5204e-43c8-4d56-93c7-35d3c1f15a9e.png)

    Bluebottle39 commented 1 year ago

    Hello, I have the same issue but without RimHUD. It looks like its the same popup as in the bio.

    Diakon5 commented 1 year ago

    https://github.com/Dubwise56/Rimatomics/blob/ea1eab69ea641612a46ef6951a294ab8ae352b0d/Languages/English/Keyed/Rimatomics.xml#L273

    This translation key must be accidentally overriding a vanilla one, no clue where it's used due to a lack of source code.

    Sindusk commented 1 year ago

    https://github.com/Dubwise56/Rimatomics/blob/ea1eab69ea641612a46ef6951a294ab8ae352b0d/Languages/English/Keyed/Rimatomics.xml#L273

    This translation key must be accidentally overriding a vanilla one, no clue where it's used due to a lack of source code.

    This is correct and the SkillLevel key is not translated in any of the code that I could read from decompiling the assembly. This key can be removed.