search

DuelMonster / MinersAdvantage

MinersAdvantage is a reimagening of my previous mod 'SuperMiner'. It is a rewrite from the ground up that aims to solve all previous issues and to add additional features.
GNU Lesser General Public License v3.0
21 stars 1 forks source link

Possible Minecolonies compatibility issue #38

Open DuelMonster opened 4 years ago

DuelMonster commented 4 years ago

Issue description:

Reported on CurseForge by mykkitno: Jan 24, 2020

I think I may have found a conflict with another mod, called Minecolonies. https://www.minecolonies.com. It works great when I put in the first building, either the supply ship, or the supply camp, but once I add the other buildings, it stops. It's a weird little glitch too, you can see that the mod wants to work because the little black dots appear over the blocks you try to destroy, but you only end up destroying one. If you need more info, please let me know.

0xebjc commented 4 years ago

Confirmed, this is a repeatable issues.

Version:

Minecolonies: minecolonies-1.12.2-0.10.714-RELEASE-universal.jar Minecraft: 1.12.2 Forge: 14.23.5.2847 MinersAdvantage: MinersAdvantage-1.12.2-1.3.19.243.jar

Expected behavior:

Using MinersAdvantage to mine a complete vein of an ore, or mine a shaft of blocks, or cut down an entire tree, basically all the MinersAdvantage features to work.

Actual behavior:

MinersAdvantage works as expected outside of colony boundaries. Inside a minecolonies colony boundary it does not function. I have verified this by holding the structurize tool in my hand to see the mineconlony boundary. Going outside of the boundary MinersAdvantage work as expected. Going into the minecolony boundary MinersAdvantage no longer functions. It seems that the pathanation function still seems to work at times, but the shaftanation, vienation, and lumbination no longer work.

Steps to reproduce the problem

  1. Run Minecraft 1.12.2 with forge 14.23.5.2847, minecolonies-1.12.2-0.10.714-RELEASE-universal.jar, and MinersAdvantage-1.12.2-1.3.19.243.jar. create a server and client game, run the server, then login from a separate client system.
  2. Create a supply ship and place it.
  3. Get the Town hall and structurize tool.
  4. Place the Town hall, and start a new colony
  5. Start a builders hut, ( I usually start 3 builders huts )
  6. Try to use the 'grave key' or alt key to mine blocks with pickaxe inside the colony boundary, MinersAdvantage no longer works.
  7. Try to mine an ore with a pickaxe inside the minecolony boundary, MinersAdvantage no longer works.
  8. Try to chop down an entire tree with an axe inside the colony boundary, MinersAdvantage no longer works.
  9. Using the structurize tool in main hand to view the minecolony boundary, go outside the minecolony boundary
  10. Perform steps in 6, 7 & 8, to accomplish mining, shaftination, vienation, and lumbination, all outside the minecolony boundary. All MinersAdvantage functions work correctly.

Logs:

None produced.

0xebjc commented 4 years ago

I got feedback from the minecolonies dev team, basically MinersAdvantage needs to apply the user UUID to each block as it is mining to fix this issue.

commented here: https://github.com/ldtteam/minecolonies/issues/4458

0xebjc commented 4 years ago

Raycoms commented:

basically he has to call the breakBlock method that gets a player and give it the player that is using the tool. And not set the block air and drop it. That should be all that's needed.