Dueris / OriginsPaper

Custom Origins Plugin for PaperMC
https://modrinth.com/plugin/originspaper
Other
27 stars 6 forks source link

[BUG] - #46

Closed A53o closed 1 year ago

A53o commented 1 year ago

Describe the bug I'm getting an error on server startup

Plugin Version 0.2.1

Minecraft version 1.20.1

Server software Paper

Steps to reproduce start the server

What should happen? no errors and startup fine

What is happening instead? Error

Stacktrace/Errors on Console https://pastebin.com/c3tdFxX3

Dueris commented 1 year ago

Damnit why is it always this bug ;-;. To explain the bug, it's a bug in the conversion of origin data types bc it changed in that update. Basically the reading is broken. Due to it being an old version there isn't much I can do, but the only fix for 0.2.1 that we found was by deleting the playerdata folder for the user who caused the error. I have a copy on my pc that I'm working on to hopefully fix this error in the next version. Just haven't pushed anything in a while lol, also been working on a new project. Anyway, 0.2.3 will have a fix if everything goes well(prob 1.20.2 maybe). Sry

A53o commented 1 year ago

When do you think it will be released? I think I can do 1.20.2 it just depends on if day night PVP works on 1.20.2 bc that is the only other plugin I have or is there an older version that works on 1.20.1 that does not have this bug

Dueris commented 1 year ago

Sry I meant the file not the folder, apologies. In the logs above where the error is printed you should see something abt the player logging in with something and it's a bunch of numbers and letters separated by a dash. That's the uuid. Go to ur overworld folder, then the datapacks folder, and delete the files that match that uuid, they should be a .dat file and a .dat_old

A53o commented 1 year ago

Do I have to do that for every player also when I join the server it puts me in the ground huh?

A53o commented 1 year ago

Also is the error a problem the only problem I have is I spawn in the ground huh?

Dueris commented 1 year ago

Only the player that caused the error. BUT BEFORE YOU DO IT, this deletes everything for that player. Inventory, ender chest, etc. This won't delete the blocks that have been placed tho. It will delete inventory, spawn location, current location, ender chest. That's it. That's why this bug is extremely annoying lol. If u want, you can disable genesis and wait for the next update, or I can get u a build when I patch it and send it here.

The spawning in the ground I got no clue what that is lol. Been struggling to figure that one out, might be vanilla but idk. Haven't had much time to look into it lol. Been a bit busy with HighSchool and canvas(another project I'm working on)

A53o commented 1 year ago

I know what deleting the player data does I haven't opened my server yet I am only opening it once I have origins I have tried the origins plug-in itself but it's just terrible and it doesn't have all the origins

Dueris commented 1 year ago

Alright, apologies, was just making sure lol. If you delete the playerdata and you are the only one that has joined, it should be fine because that error occurs during translations of other versions. Again, the issue is still weird af and extremely annoying lol.

Sry for my late replies btw, was studying for a Calculus exam lol

A53o commented 1 year ago

It's ok lol

Dueris commented 1 year ago

Try deleting the playerdata tho, if the issue pursists lmk(i doubt it would happen but who knows its a weird bug)

A53o commented 1 year ago

No it does not work I still get the error dose the error make a problem?

Dueris commented 1 year ago

damn i forgot how much i hated this bug when we first found it lmao. we are gonna try 1 last thing, if it doesnt work i will try and make a build that repatches your data(will be on 1.20.2, might just be a patched 0.2.2). try downgrading the plugin to 0.1.7, join, choose an origin, then leave, change the version back to 0.2.1, then the conversion code will execute(i hope). if not then imma cry bc 0.2.1 rewrote the entire plugin for custom origins and adding all the origins lol. normally the plugin runs fine... normally... actually i think 0.2.2 has the fixes, so you could upgrade to that along with the server version to 0.2.2. it also contains lots of patches for 0.2.1. im really sorry for this issue, 0.2.1 was kinda broken lolll

A53o commented 1 year ago

So do I just have to upgrade my server to Minecraft 1.20.2 and upgrade to the plugin to 0.2.2 because I can do that I think I think that would just be simpler to upgrade the server and plugin also don't worry about anything you're doing your best

Dueris commented 1 year ago

0.1.7 may not have this bug, but some origins won't work bc they all weren't fully coded. 0.2.1 was a rly buggy version, and idk when 0.2.3 is releasing bc I have been rly busy with stuff lately so there is no ETA. Sry

Dueris commented 1 year ago

0.2.2 should have the patch to fix things tho, so yeah, you can try upgrading your server to 1.20.2, 0.2.2.

A53o commented 1 year ago

Ok well I can do that I won't close this issue until I know that it works

Dueris commented 1 year ago

Did it work?

A53o commented 1 year ago

I haven't tested it yet it's 8 am right now for me so

A53o commented 1 year ago

I'll get back to you once I've tested it

Dueris commented 1 year ago

Alrighty

A53o commented 1 year ago

well I installed 0.2.2 but the proxy is down and the proxy owner is not home so i need to wait lol

A53o commented 1 year ago

ok its back up

A53o commented 1 year ago

it works!!! but i still spawn in the ground but it may just be lag but idk

Dueris commented 1 year ago

I'm glad it works, I can look into the spawning in the ground bug later.

A53o commented 1 year ago

its not a bug its lag my server tps was 1591 ticks behind 💀

Dueris commented 1 year ago

Oop

therealrelic commented 1 year ago

when I do /origin gui therealrelic. it says an internal error occurred while attempting to perform this command. I've already retry to reinstall the plugin.

Dueris commented 1 year ago

Could you provide your server version, server type, plugin type, and any logs you can from the server?

A53o commented 1 year ago

hay is there a why to optimise this plugin bc its very laggy

Dueris commented 1 year ago

Honestly it's quite difficult due to how the plugin runs. Which part is laggy? I can try and fix it

A53o commented 1 year ago

When a player joins it kills the TPS before I had the plugin the server was I have had 5 players on at once and the server was fine

Dueris commented 1 year ago

Does it stay down or does it drop for a few seconds to a minute? Also, could you provide a spark profiler report of you doing the following:

A53o commented 1 year ago

Pretty much everything because it just kills the TPS the server goes 1500 ticks behind or my server is just not powerful eough

Dueris commented 1 year ago

Alright yeah imma need that spark report, i will try and optimize what's causing the performance issues

A53o commented 1 year ago

What's the spark report? also thx do what you can

Dueris commented 1 year ago

Download the spark plugin first Then restart the server and run /spark profiler start Do the things in the list I sent and try and space out the actions, make the report about 3 minutes or more. Then run /spark profiler stop and send the link it provides here

A53o commented 1 year ago

Ok I'll do that when I get home

A53o commented 1 year ago

here it is https://spark.lucko.me/TobHIiUBzD

Dueris commented 1 year ago

Judging by the tasks being run I'm assuming u got Enderian?

Dueris commented 1 year ago

Screenshot_20231025_194143_Chrome Ah yes 72% thread usage sounds just fine(it's not lmfao)

A53o commented 1 year ago

yep

Dueris commented 1 year ago

And a good 71% of that is being taken up by 1 task... fun

Dueris commented 1 year ago

Oh wait I fixed this before. DID I NOT PUSH THIS!?!?!

Dueris commented 1 year ago

Anyway, it's by working with entity rendering. Enderians can't see entities and players with pumpkins on their heads, and that custom origin task is using 71% of the server thread. Hold on a few minutes imma get u a working build, try that and send another report

A53o commented 1 year ago

ok cool so is it just the Enderian

Dueris commented 1 year ago

Yeah when 0.2.2 was released that power was VERY unoptimized so it was going over every single entity in the entire world checking rendering methods

Dueris commented 1 year ago

Now it at least SHOULD be better. If not then rip

A53o commented 1 year ago

ok

Dueris commented 1 year ago

I'm working on my remote ide system and it's taking so long to build lmao. May be a bit longer for a more optimized build

A53o commented 1 year ago

ok its fine