DurgNomis-drol / mytoyota

Python client for Toyota Connected Services API
MIT License
81 stars 33 forks source link

Fix: Make `unit` and `value` optional #286

Closed CM000n closed 10 months ago

CM000n commented 10 months ago

The Toyota API is really strange in some places. Why should I return unit and value but then leave them empty πŸ˜• See: https://github.com/DurgNomis-drol/mytoyota/issues/280#issuecomment-1883129546

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (09b3af8) 72.47% compared to head (ffc44d7) 72.47%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #286 +/- ## ======================================= Coverage 72.47% 72.47% ======================================= Files 28 28 Lines 1355 1355 ======================================= Hits 982 982 Misses 373 373 ``` | [Flag](https://app.codecov.io/gh/DurgNomis-drol/mytoyota/pull/286/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Hansen) | Coverage Ξ” | | |---|---|---| | [unittests](https://app.codecov.io/gh/DurgNomis-drol/mytoyota/pull/286/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Hansen) | `72.47% <100.00%> (ΓΈ)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Hansen#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.