DynamoDS / Dynamo

Open Source Graphical Programming for Design
https://dynamobim.org
Other
1.74k stars 634 forks source link

DYN-7796 Open Template Locale #15657

Closed RobertGlobant20 closed 1 week ago

RobertGlobant20 commented 1 week ago

Purpose

Fixing Templates path locale when Revit is in a different language than English When Revit Language is French and we open Dynamo Language = Default (inherits Revit Language) if we try to open a template the file explorer location was always en-US. In this fix I'm setting the PreferenceSettings.TemplateFilePath property if the CurrentCulture doesn't match with the locale path used for the templates, also this value will be reflected in DynamoSettings.xml.

Declarations

Check these if you believe they are true

Release Notes

Fixing Templates path locale when Revit is in a different language than English

Reviewers

@QilongTang @reddyashish

FYIs

RobertGlobant20 commented 1 week ago

GIF showing the expected behavior in French. Revit_BvACGUFDQG

RobertGlobant20 commented 1 week ago

GIF showing the expected behavior in Spanish. Revit_8H9O0v32Yg

github-actions[bot] commented 1 week ago

UI Smoke Tests

Test: success. 11 passed, 0 failed. TestComplete Test Result Workflow Run: UI Smoke Tests Check: UI Smoke Tests

QilongTang commented 1 week ago

@RobertGlobant20 Would you also cherry-pick this? Covered in https://github.com/DynamoDS/Dynamo/pull/15664