DYN-7716 Fixing Flaky Tests

RobertGlobant20 commented 1 day ago

Purpose

DYN-7716 Fixing Flaky Tests Fixing flaky tests that sometimes are failing and sometimes are not failing. There are some tests that sometimes are failing and sometimes are not failing so those test were marked as Category[Failure]. So in this fix I'm removing that Category and make changes to fix the tests and get more info about why are failing. This is the list of tests failing

LuceneSearchTSplineNodesOrderingValidation()
NodeSuggestions_OutputPortBuiltInNode_AreCorrect()
NodeSuggestions_CanAutoCompleteOnCustomNodesOutPort_WithSpaceInPortName()

I've run the DYN-DevCI_Self_Service job two times without any test failing (also local tests in VS2022 are passing) but I will continue checking if in the jobs there are failing test in this PR

Declarations

Check these if you believe they are true

[X] The codebase is in a better state after this PR
[X] Is documented according to the standards
[X] The level of testing this PR includes is appropriate
[X] User facing strings, if any, are extracted into *.resx files
[ ] All tests pass using the self-service CI.
[ ] Snapshot of UI changes, if any.
[ ] Changes to the API follow Semantic Versioning and are documented in the API Changes document.
[ ] This PR modifies some build requirements and the readme is updated
[ ] This PR contains no files larger than 50 MB

Release Notes

Fixing flaky tests that sometimes are failing and sometimes are not failing.

Reviewers

@QilongTang

FYIs

github-actions[bot] commented 1 day ago

UI Smoke Tests

Test: success. 11 passed, 0 failed. TestComplete Test Result Workflow Run: UI Smoke Tests Check: UI Smoke Tests

QilongTang commented 1 day ago

@RobertGlobant20 There is one regression reported but not related to the tests you turning on as part of this PR, can you check if that pass locally?

RobertGlobant20 commented 15 hours ago

@QilongTang the test failing is (I think is not related to this change):

[Test]
[Category("FailureDynCore")]
public void FeatureFlagsShouldReturnRealDataAfterCache()

"FailureDynCore" means that will be failing on DynamoCore?

Thanks

QilongTang commented 12 hours ago

that will be failing on DynamoCore?

Not sure what that means, you will need to check with who added the test. I will approve the PR for now

RobertGlobant20 commented 11 hours ago

that will be failing on DynamoCore?

Not sure what that means, you will need to check with who added the test. I will approve the PR for now

The job passed here: https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/16865/

DynamoDS / Dynamo