DynamoDS / Dynamo

Open Source Graphical Programming for Design
https://dynamobim.org
Other
1.74k stars 634 forks source link

DYN-7790 fix package tour terms of use step #15681

Closed chubakueno closed 1 day ago

chubakueno commented 1 day ago

Purpose

Dynamo.Wpf.UI.GuidedTour.GuidesValidationMethods.ExecuteTermsOfServiceFlow searches for the TermsOfUse window as owned by DynamoView in GuideUtilities.FindWindowOwned(stepInfo.HostPopupInfo.WindowName, stepInfo.MainWindow as Window) but can't find it due to it being owned by no one (null). This PR thus allows the user to complete the packages tour. Allows for dependent Package Tour testing ticket DYN-7664 to be completed.

Process without previously accepted TOU: 2024-11-21 13-50-17 Process with previously accepted TOU: 2024-11-21 13-52-39

Declarations

Check these if you believe they are true

Release Notes

Solve DYN-7790 to fix Packages interactive tour

Reviewers

@RobertGlobant20 @QilongTang

FYIs

@avidit

github-actions[bot] commented 1 day ago

UI Smoke Tests

Test: success. 11 passed, 0 failed. TestComplete Test Result Workflow Run: UI Smoke Tests Check: UI Smoke Tests

chubakueno commented 1 day ago

LGTM, could you add a GIF of the packages tour when the TermsOfUse has not been accepted yet?

Added both flows (with and without previously accepted TOU)