search

DynamoDS / Dynamo

Open Source Graphical Programming for Design
https://dynamobim.org
Other
1.74k stars 634 forks source link

ZeroTouch import exception doesn't make it to dynamo console - so is useless. #9163

Open mjkkirschner opened 6 years ago

mjkkirschner commented 6 years ago

https://github.com/DynamoDS/Dynamo/blob/master/src/Engine/ProtoCore/FFI/CLRDLLModule.cs#L284

we should do at least two things:

  1. Validity Assert simply logs to the console, we should see if we can usedynamoLogger so the message is actually present in the dyanmoConsole for users ( we could also log anotification!)
  2. send more info to the log/notification - the SuppressImport method has very clear constraints but they are not communicated via the message -only false is returned. This should be improved.

@Racel @ikeough FYI: https://github.com/DynamoDS/Dynamo/blob/master/src/Engine/ProtoCore/FFI/CLRDLLModule.cs#L612

aparajit-pratap commented 5 years ago

@mjkkirschner can we close this now that we are logging to the console and showing notifications as well? Or are you referring to other failures that fall through the cracks?

mjkkirschner commented 5 years ago

I think this should stay open, we still have not improved zero touch compiler errors (which member failed to import etc)