DynamoDS / DynamoRevit

Dynamo Libraries for Revit
https://dynamobim.org
342 stars 188 forks source link

[CLOSED] Dynamo 0.9 for Revit crashing and producing lots of nulls #2162

Closed ColinDayOrg closed 6 years ago

ColinDayOrg commented 6 years ago

Issue by jluebker Wednesday Dec 16, 2015 at 16:41 GMT Originally opened as https://github.com/DynamoDS/Dynamo/issues/5850


Lately my dynamo for Revit has been crashing a lot (even though I am running the latest stable build)... Sandbox works just fine though.

I was also getting a whole lot of nulls for no reason in this graph (even though the nodes are producing geometry --- or at least some of them are. It runs just fine in the sandbox though.

image

Here are the details of the latest crash:

The input argument "materialId" of function `anonymous-namespace'::TessellatedFace_constructor or one item in the collection is null at line 96 of file d:\sundial\2015_px64\source\api\revitapi\gensrc\APITessellatedShapeBuilder.cpp. Parameter name: materialId

at APIElementIdTypeConverter.ManagedToNative(ElementId managedObj, ElementId* nativeObj, ManagedToNativeParameter convParam) at ?A0x91c5a93f.TessellatedFace_constructor(IList1 outerLoopVertices, ElementId materialId) at Autodesk.Revit.DB.TessellatedFace..ctor(IList1 outerLoopVertices, ElementId materialId) at Revit.GeometryConversion.ProtoToRevitMesh.ToRevitType(Solid solid, TessellatedShapeBuilderTarget target, TessellatedShapeBuilderFallback fallback, ElementId MaterialId, Boolean performHostUnitConversion) at Dynamo.Applications.ViewModel.RevitWatch3DViewModel.RevitGeometryObjectFromGraphicItem(IGraphicItem item, List1& geoms) at Dynamo.Applications.ViewModel.RevitWatch3DViewModel.Draw() at Dynamo.Applications.ViewModel.RevitWatch3DViewModel.OnNodePropertyChanged(Object sender, PropertyChangedEventArgs e) at System.ComponentModel.PropertyChangedEventHandler.Invoke(Object sender, PropertyChangedEventArgs e) at Dynamo.Core.NotificationObject.RaisePropertyChanged(String propertyName) at Dynamo.Models.NodeModel.set_IsVisible(Boolean value) at Dynamo.Models.NodeModel.UpdateValueCore(UpdateValueParams updateValueParams) at Dynamo.Models.WorkspaceModel.UpdateModelValue(IEnumerable1 modelGuids, String propertyName, String value) at Dynamo.Models.DynamoModel.UpdateModelValueImpl(UpdateModelValueCommand command) at Dynamo.Models.DynamoModel.ExecuteCommand(RecordableCommand command) at Dynamo.ViewModels.WorkspaceViewModel.ShowHideAllGeometryPreview(Object parameter) at MS.Internal.Commands.CommandHelpers.CriticalExecuteCommandSource(ICommandSource commandSource, Boolean userInitiated) at System.Windows.Controls.MenuItem.InvokeClickAfterRender(Object arg) at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs) at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)

ColinDayOrg commented 6 years ago

Comment by jluebker Wednesday Dec 16, 2015 at 17:10 GMT


Update: the nulls are fixed when I turn off the preview in revit and the number of crashes reduces. But it is still crashing more than it should be or than it does in the sandbox.

ColinDayOrg commented 6 years ago

Comment by kronz Saturday Jan 02, 2016 at 04:10 GMT


@jluebker I suspect you have a really old version of Rhynamo. Looks like this is the version that was made with Python nodes inside of Custom nodes. Try updating to the latest version of that package? It's pretty different now.

ColinDayOrg commented 6 years ago

Comment by monikaprabhu Wednesday Jan 13, 2016 at 03:40 GMT


@jluebker are you still be able to reproduce this? Also are you using English revit+Dynamo or localized. We have seen crash related to preview in Revit in localized sessions. fix is here. https://github.com/DynamoDS/DynamoRevit/pull/795. I would like to know if your crash is related. So please test on the latest daily build and let me know.

ColinDayOrg commented 6 years ago

Comment by jluebker Wednesday Jan 13, 2016 at 04:10 GMT


I am having crashes but I’m pretty sure they are related to flux. Though I did have a series of crash not related to flux when I submitted this. Your description however leads me to believe that it was the spring nodes familyinstance.bygeoemtry that I was working with. I was creating families using freeformelments and was neglecting to apply a material, which might cause the crash you described.

Jeremy Luebker Arch II t 415.546.2957 c 510.881.3682 Perkins+Will

From: monikaprabhu [mailto:notifications@github.com] Sent: Tuesday, January 12, 2016 7:41 PM To: DynamoDS/Dynamo Dynamo@noreply.github.com Cc: Luebker, Jeremy Jeremy.Luebker@perkinswill.com Subject: Re: [Dynamo] Dynamo 0.9 for Revit crashing and producing lots of nulls (#5850)

@jluebkerhttps://github.com/jluebker are you still be able to reproduce this? Also are you using English revit+Dynamo or localized. We have seen crash related to preview in Revit in localized sessions. fix is here. DynamoDS/DynamoRevit#795https://github.com/DynamoDS/DynamoRevit/pull/795. I would like to know if your crash is related. So please test on the latest daily build and let me know.

— Reply to this email directly or view it on GitHubhttps://github.com/DynamoDS/Dynamo/issues/5850#issuecomment-171152864.

ColinDayOrg commented 6 years ago

Comment by ColinDayOrg Friday Oct 12, 2018 at 13:45 GMT


This issue has been moved to the DynamoRevit repo (#2160).

ColinDayOrg commented 6 years ago

Duplicate to #2161, closing